Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote map handling #48

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Conversation

itsmeow
Copy link
Contributor

@itsmeow itsmeow commented Oct 29, 2022

Adds support for specifying a full HTTP map url in the query string, and then uses that map.
This is for support with MapDiffBot-DMM, which uses map editors to show diffs. Allowing use of a web based FastDMM would be ideal

http://localhost:8000/?repo=itsmeowForks/BeeStation-Hornet&branch=93dd0b88e4527ca2e63ea3c2492d79450976646a&map=https://mdb.itsmeow.dev/map-diff/e0a7503f39a9378ad04ff463443e6f0a7fc5fda9.dmm

Functional on local server:
image

@monster860
Copy link
Owner

I will merge this for now, but I'd like this to be changed in the future so that the URL doesn't get permanently cached forever on the user's hard drive. This behavior is fine for your use-case but it might be less fine for other use-cases.

@monster860 monster860 merged commit 39c33d6 into monster860:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants