-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Documentation for MDL-75671 #1053
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
1431c27
to
e1838f6
Compare
⚡️ Lighthouse report for the deploy preview of this PR
|
e1838f6
to
4581d99
Compare
4581d99
to
c431df5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roland04!
Thanks a lot for working on https://tracker.moodle.org/browse/MDL-75671 and updating devdocs to include these changes. Well done.
As you'll see, I've only raised one super-tiny typo that should be easy to fix (it would also be great if you could rebase your branch ;-) ).
c431df5
to
fb780ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing the raised points and rebasing the branch. I'm happy to approve it :-)
I'll merge it once weeklies are rolled.
This PR is blocked and needs to land after #1035
This PR is related to https://tracker.moodle.org/browse/MDL-75671