Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Deprecated badges/view.php and course_badges system report [MDL-82503] #1101

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Aug 16, 2024

In MDL-82503, badges/index.php and badges/view.php pages and course_badges and badges system reports have been combined.
As a result, badges/view.php and course_badges have been deprecated.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit baab08c
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/66de8b6f0bb5aa00080f883e
😎 Deploy Preview https://deploy-preview-1101--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarjona sarjona added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Aug 16, 2024
Copy link
Contributor

github-actions bot commented Aug 16, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 68 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 63 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 68 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 60 🟢 95 🟢 100 🟢 100 🟢 100 Report

@sarjona sarjona changed the title [docs] Deprecated badges/view.php and course_badges system report [docs] Deprecated badges/view.php and course_badges system report [MDL-82503] Aug 23, 2024
@sarjona sarjona removed the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Sep 9, 2024
In MDL-82503, `badges/index.php` and `badges/view.php` pages and `course_badges`
and `badges` system reports have been combined.
As a result, `badges/view.php` and `course_badges` have been deprecated.
Copy link
Collaborator

@aanabit aanabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seems OK and document the linked improvement done in https://tracker.moodle.org/browse/MDL-82503. So I'm fine to Approve this commit.

@sarjona sarjona added this pull request to the merge queue Sep 9, 2024
Merged via the queue into moodle:main with commit 56529b9 Sep 9, 2024
7 checks passed
@sarjona sarjona deleted the mergebadgereports branch September 9, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants