Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate new features and ideas #200

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

laurentdavid
Copy link
Collaborator

@laurentdavid laurentdavid commented Jun 9, 2022

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eb87495
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6628b184b14919000912f9e7
😎 Deploy Preview https://deploy-preview-200--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 81 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 73 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 78 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 78 🟢 95 🟢 100 🟢 100 🟢 100 Report

Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things

general/community/contribute/new-features-ideas.md Outdated Show resolved Hide resolved
general/community/contribute/new-features-ideas.md Outdated Show resolved Hide resolved
general/community/contribute/new-features-ideas.md Outdated Show resolved Hide resolved
sidebars/general.js Outdated Show resolved Hide resolved
@andrewnicols andrewnicols marked this pull request as draft June 14, 2022 03:15
@andrewnicols
Copy link
Member

I'm converting this back to a draft because we discussed that it may be better to merge this into another page as this one does not really offer very much.

@laurentdavid
Copy link
Collaborator Author

I merged the new feature and ideas page into the contribute (community) page. Not sure if I was right to add it this way to the migrated pages (I pointed to the contribute page).
It looks better and all info is now on one page.

image

@sarjona sarjona marked this pull request as ready for review April 24, 2024 11:38
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laurentdavid!
Thanks for helping with the migration of this page. I agree that merging it with the current Contributing page makes sense and, although I'm not sure if having all the information as an admonition is the best way to display it, I'm happy to merge it and see what other people think about it :-)

@sarjona sarjona dismissed andrewnicols’s stale review April 25, 2024 05:30

I've just checked that Laurent implemented all these requested changes :-)

@sarjona sarjona added this pull request to the merge queue Apr 25, 2024
Merged via the queue into moodle:main with commit 328ebb6 Apr 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Migrate New_feature_ideas
3 participants