Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Migrate Plugin contribution docs #696

Merged
merged 4 commits into from
Aug 11, 2023
Merged

[docs] Migrate Plugin contribution docs #696

merged 4 commits into from
Aug 11, 2023

Conversation

vmdef
Copy link
Contributor

@vmdef vmdef commented Aug 7, 2023 •
edited by gitpod-io bot
Loading

The remaining plugin contribution documentation is being migrated.

@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 792ff83
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/64d4f45c9447a500085f1dc2
😎 Deploy Preview https://deploy-preview-696--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 46 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 51 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 52 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🔴 48 🟠 87 🟢 92 🟢 100 🟢 100 Report

@vmdef vmdef requested a review from sarjona August 7, 2023 21:27
@vmdef
Copy link
Contributor Author

vmdef commented Aug 7, 2023

Hello @sarjona, would you be able to review the final migration of the plugin contribution documentation? Thank you.

sarjona
sarjona requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @vmdef!
Thanks for migrating the rest of the Plugins contribution dev pages! Well done! As you can see, I raised a few suggestions that I think will help to improve them :-)

general/community/plugincontribution/checklist.md Outdated Show resolved Hide resolved
general/community/plugincontribution/checklist.md Outdated Show resolved Hide resolved
general/community/plugincontribution/checklist.md Outdated Show resolved Hide resolved
general/community/plugincontribution/checklist.md Outdated Show resolved Hide resolved
general/community/plugincontribution/checklist.md Outdated Show resolved Hide resolved
general/community/plugincontribution/pluginsdirectoryapi.md Outdated Show resolved Hide resolved
general/community/plugincontribution/pluginsdirectoryapi.md Outdated Show resolved Hide resolved
general/community/plugincontribution/pluginsdirectoryapi.md Outdated Show resolved Hide resolved
general/community/plugincontribution/pluginsdirectoryapi.md Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@vmdef
Copy link
Contributor Author

vmdef commented Aug 10, 2023 •
edited
Loading

Dear @sarjona,

Thank you for your thoughtful review and valuable suggestions. I have made the following changes through new commits:

  • Improved formatting
  • Added a subsection for Guardians
  • Added a subsection for the Plugins directory

@vmdef vmdef requested a review from sarjona August 10, 2023 13:29
sarjona
sarjona requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @vmdef!
Thanks for reviewing the doc and including the suggestions! As you'll see, there are only a couple of minor things to review (and then it will be ready to be merged!).

general/community/plugincontribution/checklist.md Outdated Show resolved Hide resolved
general/community/plugincontribution/codeprechecks.md Outdated Show resolved Hide resolved
@vmdef
Copy link
Contributor Author

vmdef commented Aug 10, 2023

Hi @sarjona!
Thank you for your prompt review and patience. I have incorporated the suggested modifications into the existing commit "Apply suggestions from code review" (85683cc) in order to maintain a cleaner history.

sarjona
sarjona approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola Víctor!
Thanks!! These pages look great and it's great they have been migrated. Well done! <3

@sarjona sarjona added this pull request to the merge queue Aug 11, 2023
Merged via the queue into moodle:main with commit fe3fb36 Aug 11, 2023
7 checks passed
@vmdef vmdef deleted the plugin-docs branch August 11, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarjona sarjona sarjona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmdef @sarjona