[docs] - plugin checklist approval blockers

[danmarsden]

adds some common approval blockers to the checklist - in particular the security guidelines and significant namespace collisions are typical blockers.

@mudrd8mz good to have a +1 from you (or a -1) :-)

first dev docs PR so let me know if I've got something wrong...

[netlify]

✅ Deploy Preview for moodledevdocs ready!

Name	Link
🔨 Latest commit	1e9f7df
🔍 Latest deploy log	https://app.netlify.com/sites/moodledevdocs/deploys/64fe69512a89700008e31bb0
😎 Deploy Preview	https://deploy-preview-709--moodledevdocs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[andrewnicols]

This looks good to me. I'm happy to merge it now if you want? Or you can wait for David to take a peek first. Your choice? We can always land this and then create a new issue if there is more to add.

[github-actions]

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🔴 45	🟠 87	🟢 92	🟢 90	🟢 100	Report
/docs/apis/commonfiles	🔴 41	🟠 85	🟢 92	🟢 100	🟢 100	Report
/general/development/gettingstarted	🟠 50	🟠 87	🟢 92	🟢 90	🟢 100	Report
/general/releases	🟠 52	🟠 87	🟢 92	🟢 100	🟢 100	Report

[andrewnicols]

Ah - linting check is failing. This is something you can fix automatically:

yarn mdfix-all

Essentially this is complaining because you're referencing another document in the same section (general vs. docs). Where we do that we use a relative link to the markdown file because it allows better link checking.

[mudrd8mz]

Many thanks @danmarsden for this. My only comment would be that the "Compliance with security guidelines" does not fit well into the "[something] that will prevent your plugin from being approved". The intention here was to list the approval blockers. So the blocker here could be something like "Violation of security guidelines" or so, no?

[andrewnicols]

I've amended the branch and force-pushed it.

Note: Probably best not to branch it to main.