Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Message API #743

Merged
merged 2 commits into from
Sep 18, 2023
Merged

[docs] Message API #743

merged 2 commits into from
Sep 18, 2023

Conversation

crnfpp
Copy link

@crnfpp crnfpp commented Sep 18, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 0844c45
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6508389beb846900088022b8
😎 Deploy Preview https://deploy-preview-743--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 32 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 55 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 52 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🔴 48 🟠 87 🟢 92 🟢 100 🟢 100 Report

Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your change here.

The changes look pretty good. I've just added a commit to your branch to:

  • correct some typos
  • update coding style to meet current coding style

We can do more to improve this documentation but we'll do so in a different issue.

Thanks for your contributions!

@andrewnicols andrewnicols added this pull request to the merge queue Sep 18, 2023
Merged via the queue into moodle:main with commit 84d3bdd Sep 18, 2023
8 of 9 checks passed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey,I am new to contributing,
I am trying to contribute by migrating css-coding-style but I can't decide on what to write on CSS.md
did you write the contents in docs/apis/core/message/index.md by yourself or referred from any specific docs?
if so kindly comment on the docs please
thank you.

#697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants