Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of the Eth Compare page #144

Merged
merged 7 commits into from
Sep 24, 2021
Merged

First draft of the Eth Compare page #144

merged 7 commits into from
Sep 24, 2021

Conversation

albertov19
Copy link
Contributor

This PR adds the Moonbeam Vs Eth section, it includes differences in:

  • Account Balances
  • Consensus & Finality
  • Transfers API
  • RPC Support

builders/get-started/eth-compare/balances.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/consensus-finality.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Good idea.

builders/get-started/eth-compare/balances.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/balances.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/balances.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/consensus-finality.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/consensus-finality.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small things but looks good! ✨ I think this will be a highly referenced section

also, do you have index page icons for these new pages, plus the new section?

builders/get-started/eth-compare/rpc-support.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/transfers-api.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/consensus-finality.md Outdated Show resolved Hide resolved
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos. Content looks great and well-organized.

builders/get-started/eth-compare/balances.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/balances.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/consensus-finality.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/rpc-support.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/rpc-support.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/rpc-support.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/rpc-support.md Outdated Show resolved Hide resolved
builders/get-started/eth-compare/rpc-support.md Outdated Show resolved Hide resolved
hyd628 and others added 2 commits September 24, 2021 11:46
Adds sample code for finality checking using Web3.py

And a paragraph description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants