Add test to ensure gas estimate is sufficient #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
added
B5-clientnoteworthy
crystalin
approved these changes
Nov 19, 2021
| @@ -12,6 +12,6 @@ describeDevMoonbeam("Estimate Gas - Contract creation", (context) => { | |||
| from: GENESIS_ACCOUNT, | |||
| data: contract.byteCode, | |||
| }) | |||
| ).to.equal(127607); | |||
| ).to.equal(150926); | |||
There was a problem hiding this comment.
@tgmichel we should have followed your instinct and spend more time on it when you found this when unexpected :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a test case that demonstrates a bug with our gas estimation where the estimation is lower than the actual required amount.
This behavior results in Ethereum clients submitting txns that will OOG.