Fix genesis chain specs

[4meta5]

Fixes genesis chain specs so they reflect runtime configured blocks per round.

Also fixes a problem discovered wherein the per-round inflation genesis config for all networks wasn't set correctly. It assumed that inflation per round = annuual inflation / number of rounds per year. That isn't correct, @girazoki corrected this assumption a long time ago in parachain_staking::inflation.

On top of #1030

[4meta5]

No description provided.

[girazoki]

It looks to me as if constructing the InflationInfo requires reading the Round storage, but it is not set yet since that happens on build_genesis. Either hardcode them or import parachain_staking and mark build it as

min: Perbill::from_parts(Perbill::from_percent(4).deconstruct() / ::DefaultBlocksPerRound::get()),

[girazoki]

So essentially, if you dont wanna change the way InflationInfo is consctructed, I suggest something like:

InflationInfo {
		expect: Range {
			min: 100_000 * GLMR,
			ideal: 200_000 * GLMR,
			max: 500_000 * GLMR,
		},
		annual: Range {
			min: Perbill::from_percent(4),
			ideal: Perbill::from_percent(5),
			max: Perbill::from_percent(5),
		},
		round: Range {
			min: Perbill::from_parts(Perbill::from_percent(4).deconstruct() / moonbase_runtime::DefaultBlocksPerRound::get()),
			ideal: Perbill::from_parts(Perbill::from_percent(5).deconstruct() / moonbase_runtime::DefaultBlocksPerRound::get()),
			max:  Perbill::from_parts(Perbill::from_percent(5).deconstruct() / moonbase_runtime::DefaultBlocksPerRound::get()),
		},
	}

[JoshOrndorff]

The build is failing. Seems like we could use parachainstaking's Config trait. But I wonder why the compiler says it is ambiguous... Is there some other meaning of DefaultBlocksPerRound?

[4meta5]

The build is failing. Seems like we could use parachainstaking's Config trait. But I wonder why the compiler says it is ambiguous... Is there some other meaning of DefaultBlocksPerRound?

I think the trait has to be in scope. I'm going to export it from the runtime.

[girazoki]

Just use moonbase_runtime::DefaultBlocksPerRound::get()

[4meta5]

One more TS test failing, it should've failed in the base PR, but the genesis inflation wasn't updated.

[librelois]

@4meta5 It still doesn't compile, think about compiling locally before pushing, because the CI takes too long to give you the compilation errors:

error[E0603]: module `inflation` is private
   --> node/service/src/chain_spec/moonbase.rs:165:26
    |
165 |         use parachain_staking::inflation::{perbill_annual_to_perbill_round, BLOCKS_PER_YEAR};
    |                                ^^^^^^^^^ private module
    |
note: the module `inflation` is defined here
   --> /home/elois/dev/purestake/moonbeam/pallets/parachain-staking/src/lib.rs:50:1
    |
50  | mod inflation;
    | ^^^^^^^^^^^^^^

error[E0603]: module `inflation` is private
   --> node/service/src/chain_spec/moonbeam.rs:148:26
    |
148 |         use parachain_staking::inflation::{perbill_annual_to_perbill_round, BLOCKS_PER_YEAR};
    |                                ^^^^^^^^^ private module
    |
note: the module `inflation` is defined here
   --> /home/elois/dev/purestake/moonbeam/pallets/parachain-staking/src/lib.rs:50:1
    |
50  | mod inflation;
    | ^^^^^^^^^^^^^^

error[E0603]: module `inflation` is private
   --> node/service/src/chain_spec/moonriver.rs:144:26
    |
144 |         use parachain_staking::inflation::{perbill_annual_to_perbill_round, BLOCKS_PER_YEAR};
    |                                ^^^^^^^^^ private module
    |
note: the module `inflation` is defined here
   --> /home/elois/dev/purestake/moonbeam/pallets/parachain-staking/src/lib.rs:50:1
    |
50  | mod inflation;
    | ^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0603`.
error: could not compile `moonbeam-service` due to 3 previous errors

[4meta5]

It still doesn't compile, think about compiling locally before pushing, because the CI takes too long to give you the compilation errors

Yeah, I usually don't compile the node locally because it takes a long time. I'll start compiling locally to speed this up.

[librelois]

@4meta5 there are still other compilation errors, the CI is not made to serve you as a compiler, but to ensure that there are no omissions, you must compile locally otherwise you risk having too many round trips with the CI

[4meta5]

Understood, compiling locally now. Usually doesn't take as many tries as today...

you must compile locally otherwise you risk having too many round trips with the CI

I don't really get this risk, but I'm compiling the node locally now and will debug locally before the next commit.