Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test maintenance mode #1070

Merged
merged 8 commits into from
Dec 20, 2021
Merged

Test maintenance mode #1070

merged 8 commits into from
Dec 20, 2021

Conversation

joelamouche
Copy link
Contributor

@joelamouche joelamouche commented Dec 8, 2021 •
edited
Loading

What does it do?

  • Add tests for maintenance mode
  • sudo calls should still pass
  • a lot of pallets must be disabled by maintenance mode
  • also adds a test for assets.transfer, which was only tested for precompile

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@joelamouche joelamouche marked this pull request as draft December 8, 2021 17:47
@joelamouche joelamouche marked this pull request as ready for review December 10, 2021 15:05
@joelamouche joelamouche added A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority". labels Dec 10, 2021
@joelamouche joelamouche changed the title wip test maintenance mode Test maintenance mode Dec 10, 2021
@joelamouche
Copy link
Contributor Author

@girazoki ready for review

@joelamouche
Copy link
Contributor Author

@JoshOrndorff Thanks for the review. updated

@joelamouche
Copy link
Contributor Author

@girazoki ready for review

@joelamouche joelamouche merged commit 4f7fae3 into master Dec 20, 2021
@joelamouche joelamouche deleted the jlm-test-maintenance-mode branch December 20, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshOrndorff JoshOrndorff JoshOrndorff left review comments

@girazoki girazoki girazoki approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelamouche @JoshOrndorff @girazoki