Increase client version to v0.17.0 #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
the
B5-clientnoteworthy
JoshOrndorff
approved these changes
Dec 16, 2021
tgmichel
suggested changes
Dec 16, 2021
| @@ -1,5 +1,7 @@ | |||
| # This file is automatically @generated by Cargo. | |||
| # It is not intended for manual editing. | |||
| version = 3 | |||
There was a problem hiding this comment.
this should not be included I believe
There was a problem hiding this comment.
I think it does, cargo adds it automatically, it's a new version of the Cargo.lock format that will have to be integrated anyway, might as well do it now
There was a problem hiding this comment.
Previously we didn't want to include it but I'm good with including it if everyone agrees.
There was a problem hiding this comment.
I'm surprised it is added now. Why, if it is automatic, wasn't it added before ?
There was a problem hiding this comment.
Because I updated my rust toolchain
|
Looks good to me too |
girazoki
approved these changes
Dec 16, 2021
tgmichel
approved these changes
Dec 16, 2021
crystalin
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?