Girazoi include dmp and xcmp in parachain system 1102 #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
approved these changes
Jan 13, 2022
librelois
added
the
B7-runtimenoteworthy
librelois
deleted the
girazoi-include-dmp-and-xcmp-in-parachain-system-1102
branch
4meta5
added a commit
that referenced
this pull request
Jan 24, 2022
…fix extrinsic to remove leftover delegation requests (#1207) * upgrade runtime to 1101 * Point nimbus to 27979c7d (fix modulo-bias issue) * Update frontier pin * Point to nimbus 10fc71cb (fix nimbus compilation) * Girazoi include dmp and xcmp in parachain system 1102 (#1172) * Include the dmp and xcmp queues in cumulus-parachain system * Reserved dmp weight * fix proposal (authorizeUpgrade) computation (#1115) * fix proposal (authorizeUpgrade) computation * index is 2 * remove temporary code * increase spec_version to 1102 * Adds test to verify delegator status after collator exit * patch existing code but still need migration * hotfix extrinsic to remove all delegation requests that lack corresponding delegations * hotfix extrinsic unit test * add benchmark code * run benchmarking and use generated weight for hotfix extrinsic * saturating sub * add comment and revert spec version bumps * more comprehensive execute leave candidates benchmark todo generate weights * update extrinsic format and unit tests and precompile interface and precompile unit tests and benchmarking todo run it * weights generated by benchmarking look more conservative now Co-authored-by: librelois <c@elo.tf> Co-authored-by: tgmichel <telmo@purestake.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com> Co-authored-by: Crystalin <alan@purestake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Include dmp and xcmp queues in 1102
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?