Remove perf-test sys-info feature #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
added
A0-pleasereview
notlesh
added
the
D3-trivial
crystalin
approved these changes
Jan 18, 2022
crystalin
added
A6-seemsok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes
perf-test'ssys-infofeature.The goal of this feature when it was originally written was to collect system info to help put the test results in perspective.
However, this ballooned into a lot of different 3rd party dependencies, none of which seemed very mature or resilient. In addition, it has produced lots of crashes and compile errors on unusual environments.
If we want to replace this feature, I think the first thing I would do is look for a bash script or similar that can collect this info rather than bake it into our binary.