Fix non-deterministic build (use paste! instead of gensym!) #1328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
In the ERC20 balances precompile we impl storage prefixes for each possible instance of pallet_balances. To avoid name clashes and long macro lines we make a dedicated module for each instance in which we create the storage prefix struct.
Before I used
gensym!
to generate a unique name for the module, but it's non-deterministic and thus cause issues with sr-tool.This PR uses
paste!
instead to generate a module name from the instance struct name, providing a unique but deterministic name.What important points reviewers should know?
Is there something left for follow-up PRs?
Maybe concatenate the literal automatically, and even loop throught 0 to 16 to avoid calling the macro multiple times?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?