eth blocks cache: add prometheus metrics & replace blocks size by bytes size #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B0-silent
tgmichel
approved these changes
Mar 28, 2022
librelois
changed the title
nanocryk
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It's a moonbeam companion for this PR: moonbeam-foundation/frontier#53
Add 6 prometheus metrics:
frontier_eth_blocks_cache_size: size of the blocks cache in bytesfrontier_eth_blocks_cache_hits: hits of the blocks cache since the node startingfrontier_eth_blocks_cache_miss: miss of the blocks cache since the node startingfrontier_eth_statuses_cache_size: size of the statuses cache in bytesfrontier_eth_statuses_cache_hits: hits of the statuses cache since the node startingfrontier_eth_statuses_cache_miss: miss of the blocks statuses since the node startingWhat important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?