Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clippy and rustfmt to CI #143

Merged
merged 14 commits into from
Jan 4, 2021
Merged

Add clippy and rustfmt to CI #143

merged 14 commits into from
Jan 4, 2021

Commits on Dec 18, 2020

  1. Add clippy/rustfmt checks to CI 

    Add clippy check to CI

Apply uses correctly

Specify runs-on

Use checkout specified from check-prettier

Try specifying toolchain with clippy as components

Apply to correct action

Specify nightly without date

Use 'rustup component add clippy' instead of toolchain

Uses on steps

Typo

Specify rustfmt and clippy in rust-toolchain file

Try only rustfmt

Undo

Revert rust-toolchain file

Add --workspace arg to clippy
    @notlesh
    notlesh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    af0a725 View commit details
    Browse the repository at this point in the history

  2. rustup clippy in init.sh

    @notlesh
    notlesh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    f5d40aa View commit details
    Browse the repository at this point in the history

  3. Introduce 'install toolchain' step for Clippy

    @notlesh
    notlesh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    cf3bd64 View commit details
    Browse the repository at this point in the history

  4. Add rustfmt check 

    Add rustfmt check

--
    @notlesh
    notlesh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    045709b View commit details
    Browse the repository at this point in the history

  5. Update .rustfmt.toml to remove license checking (for now)

    @notlesh
    notlesh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    74ae1d8 View commit details
    Browse the repository at this point in the history

  6. Enforce rustfmt rules on codebase

    @notlesh
    notlesh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    6f4e984 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Update Cargo.lock

    @notlesh
    notlesh committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    789a144 View commit details
    Browse the repository at this point in the history

  2. Resolve clippy complaints

    @notlesh
    notlesh committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    99563e3 View commit details
    Browse the repository at this point in the history

  3. Apply rustfmt

    @notlesh
    notlesh committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    b873808 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Appease clippy @ node/parachain/src/chain_spec.rs 

    Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
    @notlesh @JoshOrndorff
    notlesh and JoshOrndorff authored Dec 28, 2020
    Configuration menu
    Copy the full SHA
    d1404db View commit details
    Browse the repository at this point in the history

  2. Prefer unwrap_or_else to unwrap_or

    @notlesh
    notlesh committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    9b07d2b View commit details
    Browse the repository at this point in the history

  3. Avoid borrowed-box

    @notlesh
    notlesh committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    bc65b15 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2020

  1. Merge branch 'master' into notlesh-add-code-checks-to-ci

    @JoshOrndorff
    JoshOrndorff committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    e6e43c8 View commit details
    Browse the repository at this point in the history

  2. Add a pre-commit hook for rustfmt/clippy using rusty-hook

    @notlesh
    notlesh committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    c9042b3 View commit details
    Browse the repository at this point in the history