Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP2612: fix timestamp units #1451

Merged
merged 2 commits into from
May 2, 2022
Merged

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented May 2, 2022

What does it do?

EIP2612 and Ethereum blocks deals with timestamps in seconds, while our pallet_timestamp deals with milliseconds.
With thus need to divide by 1000 so that dapps used to EIP2612 on Ethereum don't need to handle milliseconds.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nanocryk nanocryk added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels May 2, 2022
@nanocryk nanocryk requested a review from crystalin May 2, 2022 16:18
@librelois librelois mentioned this pull request May 2, 2022
12 tasks
@librelois librelois merged commit db4f6b5 into master May 2, 2022
@librelois librelois deleted the jeremy-eip2612-fix-timestamp branch May 2, 2022 17:41
librelois pushed a commit that referenced this pull request May 2, 2022
* fix timestamp units

* update tests
@crystalin crystalin added A8-mergeoncegreen Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants