Wire author inherent to pallet ethereum #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshOrndorff
added
A0-pleasereview
crystalin
approved these changes
Feb 1, 2021
crystalin
reviewed
Feb 1, 2021
JoshOrndorff
deleted the
joshy-wire-author-inherent-to-pallet-ethereum
branch
nanocryk
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Takes the author information provided by the author inherent, and feeds it into pallet Ethereum where it can be put into the ethereum-style block's
beneficiaryfield. Previously this information came from aura in the standalone node and was stubbed to0x00...00in the parachain node.What value does it bring to the blockchain users?
Users who interact with the chain using only (or primarily) Ethereum RPC endpoints will still get to know the block author.
Checklist