Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more AuthorMapping precompile getters #2143

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Add more AuthorMapping precompile getters #2143

merged 5 commits into from
Mar 6, 2023

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented Mar 2, 2023 •
edited by crystalin
Loading

Adds more getters in AuthorMapping precompile:

    /// @dev Get the nimbus ID of the given addresss
    function nimbusIdOf(address who) external returns (bytes32);

    /// @dev Get the address of the given nimbus ID
    function addressOf(bytes32 nimbusId) external returns (address);

    /// @dev Get the keys of the given nimbus ID
    function keysOf(bytes32 nimbusId) external returns (bytes memory keys);

@nanocryk nanocryk added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Mar 2, 2023
@nanocryk nanocryk merged commit c738580 into master Mar 6, 2023
@nanocryk nanocryk deleted the jeremy-author-mapping-getters branch March 6, 2023 10:32
@crystalin crystalin changed the title AuthorMapping precompile getters Add more AuthorMapping precompile getters Apr 13, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@nanocryk @imstar15
AuthorMapping precompile getters (moonbeam-foundation#2143)
9a89715 
* nimbusIdOf

* addressOf

* keysOf

* no_std

* fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanocryk @librelois