Update evm to 0.39 #2312
Merged
Update evm to 0.39 #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
Fixed parameter in execute is_precompile_or_fail check format
fgamundi
force-pushed
the
upgrade-evm-0.39
branch
from
58b85a9
to
cdefcf4
Compare
|
Coverage generated "Mon May 29 09:16:54 UTC 2023": Master coverage: 70.88% |
crystalin
approved these changes
May 25, 2023
| fn is_precompile(&self, address: H160, _gas: u64) -> ::fp_evm::IsPrecompileResult { | ||
| fp_evm::IsPrecompileResult::Answer { | ||
| is_precompile: <#impl_type>::#discriminant_fn(address).is_some(), | ||
| extra_cost: 0, |
There was a problem hiding this comment.
What does that extra_cost mean ?
There was a problem hiding this comment.
The associated cost of checking if it is a precompile
tgmichel
suggested changes
May 26, 2023
tgmichel
added
the
A10-evmtracing
tgmichel
approved these changes
May 29, 2023
timbrinded
pushed a commit
that referenced
this pull request
Jun 2, 2023
* Update evm to 0.39 * Adapted tests Fixed parameter in execute is_precompile_or_fail check format * Removed unused imports * Wip fallible discriminant * fmt * wip fix test assets costs * fix test assets costs * TODO temp ignore precompile macro tests --------- Co-authored-by: tgmichel <telmo@purestake.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com>
librelois
added
not-breaking
notlesh
added
D1-audited👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?