Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Do Not Merge) Perm runtime 2402 #2400

Closed
wants to merge 3 commits into from

Conversation

crystalin
Copy link
Collaborator

@crystalin crystalin commented Jul 19, 2023

We lower the MaxVotes from 512 to 20 so the Weight hint (which has a proof_size of: MaxVotes * 110917 + 176657) can fit in a Block

@crystalin crystalin changed the base branch from master to perm-runtime-2400 July 19, 2023 14:37
@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels Jul 19, 2023
@crystalin crystalin removed the D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. label Jul 20, 2023
@crystalin
Copy link
Collaborator Author

I'm removing the "nice to have audit" as this will get audited in the PR in master (which also include tests)

@crystalin crystalin closed this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants