Increase erc20 xcm gas cost #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
|
Coverage generated "Mon Jul 24 14:36:23 UTC 2023": Master coverage: 87.40% |
nbaztec
approved these changes
Jul 24, 2023
girazoki
approved these changes
Jul 25, 2023
librelois
added a commit
that referenced
this pull request
Jul 25, 2023
* improve erc20 amount conversion * increase Erc20XcmBridgeTransferGasLimit from 80,000 to 200,000 * fix ts tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The cost of an erc20-xcm transfer is necessarily static, as XCM does not support dynamic costs for assets transfer.
Historically, we fixed the constant to 80,000 , we based our decision on the fact that the ERC20 standard implementation of openzepellin use only around 33 000 gas, we therefore considered at the time that 80 000 was already a very large number, we realize that we need more gas.
But with the introduction of the GMP precompile, which uses wormhole wrapped contracts with ercv20-xcm, we realize that we need more gas (around 140 000).
Until we find a solution in the medium term to make the cost dynamic, this PR increases the constant to 200 000 (the same value used by Acala).
❗ Increase the fees of erc20-xcm
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?