Disable proposal submission for the Democracy pallet by rejecting the tx

[rimbi]

What does it do?

Disables the proposal submission for Democracy pallet by rejecting the transaction on the node side.

Now that the proposal submission is disabled, some test cases were either changed or deleted.

What alternative implementations were considered?

• A better version of this solution would disable the submit button on the UI but it is not possible with the polkadot.js as it is not maintained with us.
• Also, it is not possible to return a custom error message to users instead of invalid transaction.

What value does it bring to the blockchain users?

It is a step in moving from Gov1 to Gov2.

[crystalin]

If propose is disabled, what is the purpose to keep the democracy pallet ?
(Also it means that we won't be able to fast-track on our internal testnet anymore)

Propose will be disabled for normal user but the Council can still propose (and propose external)

[tmpolaczyk]

I don't see RuntimeCall::Democracy in the MaintenanceFilter, does that mean that proposals would actually be allowed in maintenance mode?

[librelois]

@rimbi please apply the same changes to the maintenance filter

[rimbi]

If propose is disabled, what is the purpose to keep the democracy pallet ? (Also it means that we won't be able to fast-track on our internal testnet anymore)

Propose will be disabled for normal user but the Council can still propose (and propose external)

via Democracy? @noandrea

[crystalin]

If propose is disabled, what is the purpose to keep the democracy pallet ? (Also it means that we won't be able to fast-track on our internal testnet anymore)
Propose will be disabled for normal user but the Council can still propose (and propose external)

via Democracy? @noandrea

No, via the Council, they can propose on democracy (usually as external proposal but it doesn't have to be), which is executed as root I believe and so is not filtered

[rimbi]

Can you review it again, please? @librelois @tmpolaczyk

[github-actions]

Coverage Report

@@                         Coverage Diff                          @@
##           master   cem-disable-gov1-proposal-submit      +/-   ##
====================================================================
- Coverage   81.90%                             81.89%   -0.01%     
  Files         286                                286              
  Lines       95261                              95261              
====================================================================
- Hits        78018                              78012       -6     
+ Misses      17243                              17249       +6     

Files Changed	Coverage
/runtime/moonbase/src/lib.rs	50.13% (-0.25%)	🔽
/runtime/moonbeam/src/lib.rs	69.05% (-0.25%)	🔽
/runtime/moonriver/src/lib.rs	68.97% (-0.25%)	🔽

Coverage generated Fri Dec 8 09:16:29 UTC 2023