Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out new treasury dispatchables #2607

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Filter out new treasury dispatchables #2607

merged 1 commit into from
Jan 2, 2024

Conversation

librelois
Copy link
Collaborator

What does it do?

The 4 new treasury dispatchables can only be used to send non-native tokens. As our current configuration for pallet treasury does not allow this new functionality to be used, we're filtering out these new dispatchables for the time being.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@librelois librelois added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Jan 2, 2024
@librelois librelois merged commit 66a4c0f into master Jan 2, 2024
32 of 33 checks passed
@librelois librelois deleted the elois-treasury branch January 2, 2024 16:12
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Coverage Report

@@                Coverage Diff                @@
##           master   elois-treasury     +/-   ##
=================================================
  Coverage   81.01%           81.01%   0.00%     
  Files         287              287             
+ Lines       94254            94256      +2     
=================================================
+ Hits        76353            76354      +1     
+ Misses      17901            17902      +1     
Files Changed Coverage
/runtime/common/src/migrations.rs 90.67% (+1.27%) 🔼
/runtime/moonbase/src/lib.rs 50.66% (-0.07%) 🔽
/runtime/moonbeam/src/lib.rs 47.42% (-0.06%) 🔽
/runtime/moonriver/src/lib.rs 47.41% (-0.06%) 🔽

Coverage generated Tue Jan 2 16:13:04 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants