remove local-assets logic from assets-manager #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B7-runtimenoteworthy
Coverage Report@@ Coverage Diff @@
## master rq/remove-local-assets-from-asset-manager +/- ##
=============================================================================
- Coverage 72.51% 72.50% -0.01%
Files 229 229
- Lines 70565 70401 -164
=============================================================================
- Hits 51164 51039 -125
- Misses 19401 19362 -39
|
elfedy
approved these changes
Apr 1, 2024
ahmadkaouk
approved these changes
Apr 1, 2024
librelois
reviewed
Apr 1, 2024
librelois
reviewed
Apr 1, 2024
| @@ -493,8 +493,6 @@ pub enum CurrencyId { | |||
| SelfReserve, | |||
| // Assets representing other chains native tokens | |||
| ForeignAsset(AssetId), | |||
| // Our local assets | |||
| DeprecatedLocalAssetReserve(AssetId), | |||
There was a problem hiding this comment.
Please keep the dummy variant to avoid breaking changes for CurrencyId scale encoding
librelois
reviewed
Apr 1, 2024
| @@ -485,8 +485,6 @@ pub enum CurrencyId { | |||
| SelfReserve, | |||
| // Assets representing other chains native tokens | |||
| ForeignAsset(AssetId), | |||
| // Our local assets | |||
| DeprecatedLocalAssetReserve(AssetId), | |||
There was a problem hiding this comment.
Please keep a dummy variant here, youc an remove the (AssetId) parameter and use an empty varient named RemovedLocalAssetVariant
librelois
requested changes
Apr 1, 2024
librelois
approved these changes
Apr 1, 2024
Agusrodri
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?