Update benchmarks template and add extra read weight to pallet proxy #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
D3-trivial
Coverage Report@@ Coverage Diff @@
## master rq/update-benchmarks-template +/- ##
=================================================================
- Coverage 72.51% 72.49% -0.02%
Files 229 229
+ Lines 70565 70653 +88
=================================================================
+ Hits 51164 51219 +55
+ Misses 19401 19434 +33
|
ahmadkaouk
reviewed
Mar 27, 2024
elfedy
approved these changes
Mar 27, 2024
librelois
approved these changes
Mar 27, 2024
Agusrodri
approved these changes
Mar 27, 2024
ahmadkaouk
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds an extra read to the weight of the extrinsic
proxyofpallet_proxy.The read is not included in the benchmark computation because the benchmark on the proxy pallet is not aware of a filter in the moonbeam runtime.
The workaround in the latest runtimes was to manually add 1 read to the proxy benchmark.
What important points reviewers should know?
The benchmarks will now use an updated template.