Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'DelegationBondLessDelay' instead of 'RevokeDelegationDelay' in delegation_schedule_bond_decrease #2734

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Apr 2, 2024

What does it do?

Method delegation_schedule_bond_decrease was using the wrong constant to schedule bond_decrease requests.

What important points reviewers should know?

This does not affect previous runtimes since both constants have the same value.

@RomarQ RomarQ added the B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes label Apr 2, 2024
@RomarQ RomarQ self-assigned this Apr 2, 2024
@RomarQ RomarQ requested a review from librelois April 2, 2024 17:39
@RomarQ RomarQ added not-breaking Does not need to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Coverage Report

@@                      Coverage Diff                      @@
##           master   fix/parachain-staking-2774     +/-   ##
=============================================================
  Coverage   72.49%                       72.49%   0.00%     
  Files         229                          229             
  Lines       70489                        70489             
=============================================================
  Hits        51094                        51094             
  Misses      19395                        19395             
Files Changed Coverage

Coverage generated Tue Apr 2 18:19:30 UTC 2024

@RomarQ RomarQ merged commit 10cffc6 into master Apr 8, 2024
28 of 33 checks passed
@RomarQ RomarQ deleted the fix/parachain-staking-2774 branch April 8, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants