Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiply Erc20TransferGasLimit constant by 4 for moonbase #2768

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Apr 18, 2024

What does it do?

This PR is a followup from #2735, which increased the block gas limit by 4.

@RomarQ RomarQ self-assigned this Apr 18, 2024
@noandrea noandrea added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Apr 18, 2024
Copy link
Contributor

github-actions bot commented Apr 18, 2024

Coverage Report

@@                        Coverage Diff                         @@
##           master   rq/update-Erc20TransferGasLimit     +/-   ##
==================================================================
  Coverage   73.06%                            73.06%   0.00%     
  Files         228                               228             
  Lines       69944                             69944             
==================================================================
  Hits        51103                             51103             
  Misses      18841                             18841             
Files Changed Coverage

Coverage generated Thu Apr 18 21:44:09 UTC 2024

@noandrea noandrea mentioned this pull request Apr 18, 2024
17 tasks
@noandrea noandrea merged commit 3e6bdb3 into master Apr 18, 2024
25 of 27 checks passed
@noandrea noandrea deleted the rq/update-Erc20TransferGasLimit branch April 18, 2024 22:00
noandrea pushed a commit that referenced this pull request Apr 18, 2024
* multiply Erc20TransferGasLimit constant by 4 in moonbase

* fix test-xcm-erc20-v3-filter and test-xcm-erc20-fees-and-trap tests

* fix test test-xcm-erc20-transfer

* fix test test-xcm-erc20-v3

* fix test-xcm-erc20-excess-gas.ts

* fix comment in test

* fix tracing test

---------

Co-authored-by: Agusrodri <agusrodriguez2456@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants