Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pallet weights #2802

Merged
merged 2 commits into from
May 17, 2024
Merged

Update pallet weights #2802

merged 2 commits into from
May 17, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented May 15, 2024

What does it do?

This PR updates the pallet weights, generated by benchmarks (with production profile) performed in a specialised machine.

@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels May 15, 2024
@RomarQ RomarQ self-assigned this May 15, 2024
@RomarQ RomarQ marked this pull request as draft May 15, 2024 21:24
Agusrodri
Agusrodri previously approved these changes May 15, 2024
@RomarQ RomarQ marked this pull request as ready for review May 17, 2024 10:38
Copy link
Contributor

Coverage Report

@@                  Coverage Diff                  @@
##           master   rq/update-weights      +/-   ##
=====================================================
+ Coverage   73.06%              73.08%   +0.02%     
  Files         228                 228              
- Lines       69944               69930      -14     
=====================================================
  Hits        51103               51103              
- Misses      18841               18827      -14     
Files Changed Coverage

Coverage generated Fri May 17 10:46:31 UTC 2024

@@ -59,20 +59,22 @@ impl<T: frame_system::Config> pallet_evm::WeightInfo for WeightInfo<T> {
/// Storage: `EVM::AccountStorages` (r:1 w:0)
/// Proof: `EVM::AccountStorages` (`max_values`: None, `max_size`: None, mode: `Measured`)
/// The range of component `x` is `[1, 10000000]`.
fn runner_execute(_x: u32, ) -> Weight {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot explain this change, but seems correct.

@RomarQ RomarQ merged commit efd89b1 into master May 17, 2024
27 checks passed
@RomarQ RomarQ deleted the rq/update-weights branch May 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants