Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moonriver] Fix async-backing implementation #2804

Merged
merged 3 commits into from
May 22, 2024

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented May 21, 2024

What does it do?

Fixes some bugs present in the asynchronous backing implementation for Moonriver.

Original PR: #2776

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels May 21, 2024
Copy link
Contributor

github-actions bot commented May 21, 2024

Coverage Report

@@                           Coverage Diff                           @@
##           master   agustin-fix-moonriver-async-backing      +/-   ##
=======================================================================
- Coverage   72.85%                                72.83%   -0.02%     
+ Files         228                                   229       +1     
+ Lines       70048                                 70073      +25     
=======================================================================
  Hits        51031                                 51031              
+ Misses      19017                                 19042      +25     
Files Changed Coverage

Coverage generated Tue May 21 17:29:11 UTC 2024

librelois
librelois previously approved these changes May 21, 2024
@Agusrodri Agusrodri marked this pull request as ready for review May 21, 2024 23:28
@RomarQ RomarQ added the B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes label May 22, 2024
@Agusrodri Agusrodri merged commit 80f3022 into master May 22, 2024
29 checks passed
@Agusrodri Agusrodri deleted the agustin-fix-moonriver-async-backing branch May 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants