Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bridged assets from Asset Hub #2844

Merged

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Jun 21, 2024

What does it do?

Allows Asset Hub to be a reserve for bridged assets (parents > 2).
Allows Asset Hub to be a reserve for DOT.

What important points reviewers should know?

Allows Asset Hub to be a reserve for DOT.

This may be an issue supporting DOT from both the relaychain and Asset Hub. We need to support our Oneclick transfers feature. We can remove this, but then users would need to bridge to Asset Hub and then move the asset from Asset Hub to Moonbeam in a separate step. More info in this forum post: https://forum.polkadot.network/t/managing-sas-on-multiple-reserve-chains-for-same-asset/7538

Important: Does the Moonbeam runtime allow for execution to be paid in DOT?

Is there something left for follow-up PRs?

We still need to bed down UX .e.g How do users get assets from Asset Hub to Moonbeam and back. This may require follow up PRs.

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Bridging in liquidity from Kusama and Ethereum to Polkadot. Allowing these assets to be used on Dapps on Moonbeam.

runtime/moonbase/src/xcm_config.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@librelois librelois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the term "Foreign asset", as we already use this term for assets that come from the relay or other parachains.

Can you use the term "Bridged asset" instead?

@alistair-singh
Copy link
Contributor Author

Please don't use the term "Foreign asset", as we already use this term for assets that come from the relay or other parachains.

Can you use the term "Bridged asset" instead?

Addressed in 1a2645a

@librelois
Copy link
Collaborator

Thank @alistair-singh, the changes looks good technically, but we still need to get an approval from the Moonbeam Foundation before merging it, we'll keep you informed here

@noandrea noandrea added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes labels Jul 17, 2024
@RomarQ
Copy link
Contributor

RomarQ commented Jul 18, 2024

These changes need a cargo fmt

@noandrea noandrea added the D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. label Jul 19, 2024
@alistair-singh
Copy link
Contributor Author

These changes need a cargo fmt

Addressed in d3e8260

@noandrea noandrea dismissed librelois’s stale review July 20, 2024 08:06

the requested changes have been implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants