-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: auto-compound fail when free balance is too low #2853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
not-breaking
Does not need to be mentioned in breaking changes
labels
Jun 27, 2024
Coverage Report@@ Coverage Diff @@
## master elois-fix-auto-compound +/- ##
===========================================================
+ Coverage 81.30% 81.33% +0.03%
Files 301 301
- Lines 85701 85669 -32
===========================================================
- Hits 69675 69672 -3
- Misses 16026 15997 -29
|
RomarQ
reviewed
Jun 28, 2024
RomarQ
approved these changes
Jun 28, 2024
RomarQ
previously approved these changes
Jul 3, 2024
Agusrodri
previously approved these changes
Jul 4, 2024
test/suites/dev/moonbase/test-staking/test-delegate-with-auto-compound7.ts
Outdated
Show resolved
Hide resolved
test/suites/dev/moonbase/test-staking/test-delegate-with-auto-compound7.ts
Outdated
Show resolved
Hide resolved
…compound7.ts Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com>
…compound7.ts Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com>
Agusrodri
approved these changes
Jul 4, 2024
noandrea
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR fix a bug that impact the auto-compound of staking rewards and add a dev test to reproduce the bug.
The bug is that the auto-compound logic check if stakable amount is high enough, but this check doesn't take into account the reserve, so in some corner cases the auto-compound fail silently, then the user receive less staking rewards than expected.
Old buggy logic: stakable amount is
free- frozen
New logic (fix): stakable amount is
free + reserve - frozen
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?