benchmarks for 3100 #2878
Merged
benchmarks for 3100 #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noandrea
requested review from
a team,
pLabarta,
chexware and
librelois
and removed request for
a team
noandrea
added
B7-runtimenoteworthy
noandrea
commented
Jul 25, 2024
| // TODO: Remove this multiplication once we are comfortable with the weight estimation | ||
| // Double the weight just to mitigate the possibility of having a signature that | ||
| // takes longer to verify | ||
| .saturating_mul(1u64) |
There was a problem hiding this comment.
this multiplication doesn't do much but should not be a problem according to the audit
Coverage Report@@ Coverage Diff @@
## master noandrea-runtime-3100-benchmarks +/- ##
====================================================================
- Coverage 80.88% 80.86% -0.02%
+ Files 281 282 +1
+ Lines 81698 81713 +15
====================================================================
- Hits 66075 66074 -1
+ Misses 15623 15639 +16
|
Agusrodri
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.