Add lazy migration to set evm contract metadata #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
noandrea
added
D9-needsaudit👮
WASM runtime size check:Compared to target branchMoonbase runtime: 2184 KB (no changes) ✅ Moonbeam runtime: 2140 KB (no changes) ✅ Moonriver runtime: 2132 KB (no changes) ✅ Compared to latest release (runtime-3102)Moonbase runtime: 2184 KB (+244 KB compared to latest release) Moonbeam runtime: 2140 KB (+240 KB compared to latest release) Moonriver runtime: 2132 KB (+232 KB compared to latest release) |
TarekkMA
previously approved these changes
Sep 3, 2024
RomarQ
reviewed
Sep 3, 2024
Coverage Report@@ Coverage Diff @@
## master elois-migrate-coe-metadata +/- ##
==============================================================
+ Coverage 80.93% 80.94% +0.01%
Files 286 286
+ Lines 81965 82038 +73
==============================================================
+ Hits 66331 66402 +71
+ Misses 15634 15636 +2
|
RomarQ
previously approved these changes
Sep 6, 2024
RomarQ
approved these changes
Sep 10, 2024
noandrea
approved these changes
Sep 11, 2024
gonzamontiel
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR add a lazy migration call to set evm contract metadata for old contracts created before introduction of the metadata storage item.
The migration will be executed only on demand, as unmigrated contracts are only contracts that where deployed more than 2 years ago and never called after the introduction of metadata storage item.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
moonbeam-foundation/frontier#224
What value does it bring to the blockchain users?