(fix): Send back xcDOT to AssetHub from Moonbeam #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchMoonbase runtime: 2176 KB (no changes) ✅ Moonbeam runtime: 2140 KB (no changes) ✅ Moonriver runtime: 2140 KB (no changes) ✅ Compared to latest release (runtime-3102)Moonbase runtime: 2176 KB (+236 KB compared to latest release) Moonbeam runtime: 2140 KB (+240 KB compared to latest release) Moonriver runtime: 2140 KB (+240 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master agustin-xcDot-assetHub-fix +/- ##
==============================================================
+ Coverage 78.70% 79.40% +0.70%
Files 294 294
+ Lines 84425 87275 +2850
==============================================================
+ Hits 66440 69300 +2860
- Misses 17985 17975 -10
|
RomarQ
added
B7-runtimenoteworthy
Agusrodri
commented
Sep 9, 2024
Agusrodri
commented
Sep 10, 2024
RomarQ
reviewed
Sep 12, 2024
RomarQ
previously approved these changes
Sep 12, 2024
librelois
previously approved these changes
Sep 12, 2024
librelois
approved these changes
Sep 12, 2024
RomarQ
approved these changes
Sep 12, 2024
noandrea
pushed a commit
that referenced
this pull request
Sep 17, 2024
* initial setup * fix comments * start testing * add one more step in test * add more tests * revert changes in xtokens precompile * remove para_event() unused function * fix costs * fix more costs * use proper branch * add tests to moonriver and moonbeam * rename struct to ConcreteAssetFromRelay and add more docs * remove unneeded transfer in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR takes care of fixing xcDOTs transfers between Moonbeam chains and AssetHub, specially the case in which we want to send xcDOTs tokens from Moonbeam back to AssetHub.
The fix basically consists on modifying some code inside Xtokens pallet (in our ORML fork), for it to properly recognize AssetHub as a reserve for DOTs at the moment of executing the transfer.
What important points reviewers should know?
From what tests show, there is no need to modify our xTokens precompile for this kind of transfer to work.
Given that, I reverted the initial changes that modified the precompile adding helper functions to convert the currency_id/location.
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
moonbeam-foundation/open-runtime-module-library#7