Remove all dependencies to repository open-runtime-module-library

[librelois]

What does it do?

To reduce the complexity of moonbeam runtimes and maintenance work, we want to reduce the number of dependencies, and in particular the number of git directories.

We use the orml repository only fo xTokens pallet, which we added historically because at the time pallet-xcm was too limited. Now pallet-xcm has matured and is more stable than xTokens, so we want to remove the xTokens pallet.

⚠️ Breaking changes ⚠️

Selectors transferWithFee and transferMultiassetWithFee no longer take the fee parameter into account. Now, if you want to limit the maximum amount of fees, you'll have to use a different asset from the one you wish to transfer.

For example, if you previously transferred an asset A and used the same asset A to pay xcm fees on the destination chain, now use another asset B to pay the fees on the destination chain (and use transfer_multi* selectors to transfer assets A and B at the same time).

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

[github-actions]

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2268 KB (no changes) ✅

Moonbeam runtime: 2244 KB (no changes) ✅

Moonriver runtime: 2224 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2268 KB (+308 KB compared to latest release) ⚠️

Moonbeam runtime: 2244 KB (+320 KB compared to latest release) ⚠️

Moonriver runtime: 2224 KB (+300 KB compared to latest release) ⚠️

[github-actions]

Coverage Report

@@                  Coverage Diff                  @@
##           master   elois-remove-orml      +/-   ##
=====================================================
- Coverage   79.12%              79.09%   -0.03%     
+ Files         303                 305       +2     
+ Lines       88017               88352     +335     
=====================================================
+ Hits        69637               69877     +240     
+ Misses      18380               18475      +95     

Files Changed	Coverage
/pallets/erc20-xcm-bridge/src/erc20_trap.rs	0.00% (-68.18%)	🔽
/pallets/erc20-xcm-bridge/src/xcm_holding_ext.rs	100.00% (+5.26%)	🔼
/pallets/moonbeam-foreign-assets/src/lib.rs	70.40% (+1.34%)	🔼
/pallets/moonbeam-xcm-benchmarks/src/weights/generic.rs	2.59% (-1.67%)	🔽
/pallets/moonbeam-xcm-benchmarks/src/weights/mod.rs	9.95% (-3.66%)	🔽
/pallets/xcm-transactor/src/lib.rs	89.46% (+0.02%)	🔼
/precompiles/gmp/src/lib.rs	14.22% (-1.65%)	🔽
/precompiles/gmp/src/mock.rs	20.47% (-6.06%)	🔽
/precompiles/xtokens/src/lib.rs	96.14% (+0.44%)	🔼
/precompiles/xtokens/src/mock.rs	53.38% (-24.50%)	🔽
/precompiles/xtokens/src/tests.rs	99.43% (-0.08%)	🔽
/primitives/xcm/src/origin_conversion.rs	89.80% (+28.04%)	🔼
/runtime/common/src/weights/pallet_xcm.rs	5.26% (+5.26%)	🔼
/runtime/moonbase/src/lib.rs	52.55% (+0.01%)	🔼
/runtime/moonbase/tests/integration_test.rs	99.38% (+0.01%)	🔼
/runtime/moonbase/tests/xcm_mock/parachain.rs	61.07% (+0.22%)	🔼
/runtime/moonbeam/src/lib.rs	46.78% (+0.16%)	🔼
/runtime/moonbeam/src/xcm_config.rs	45.45% (-2.02%)	🔽
/runtime/moonbeam/tests/integration_test.rs	99.38% (+0.01%)	🔼
/runtime/moonbeam/tests/xcm_mock/parachain.rs	61.07% (+0.22%)	🔼
/runtime/moonriver/src/lib.rs	47.00% (+0.15%)	🔼
/runtime/moonriver/tests/integration_test.rs	99.36% (+0.01%)	🔼
/runtime/moonriver/tests/xcm_mock/parachain.rs	61.79% (+0.22%)	🔼
/runtime/moonriver/tests/xcm_tests.rs	99.94% (+0.01%)	🔼

Coverage generated Thu Oct 10 08:31:01 UTC 2024

[RomarQ]

Added a few remarks. But the overall changes look good to me

[gonzamontiel]

I left a comment, overall it looks good to me.
I did a quick search for 'orml' and there are some matches in typescript-api, but I guess they will be gone when updating the augmented api.