Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weights for runtime 3300 #2999

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Conversation

noandrea
Copy link
Collaborator

What does it do?

Update the weights for runtime 3300 after running the benchmarks

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@noandrea noandrea added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2268 KB (no changes) ✅

Moonbeam runtime: 2240 KB (no changes) ✅

Moonriver runtime: 2228 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2268 KB (+308 KB compared to latest release) ⚠️

Moonbeam runtime: 2240 KB (+316 KB compared to latest release) ⚠️

Moonriver runtime: 2228 KB (+304 KB compared to latest release) ⚠️

@noandrea noandrea merged commit fea3b49 into master Oct 10, 2024
31 of 33 checks passed
@noandrea noandrea deleted the noandrea-runtime-3300-benchmarks branch October 10, 2024 14:10
Copy link
Contributor

Coverage Report

@@                         Coverage Diff                          @@
##           master   noandrea-runtime-3300-benchmarks      +/-   ##
====================================================================
- Coverage   79.09%                             79.08%   -0.01%     
  Files         305                                305              
+ Lines       88352                              88361       +9     
====================================================================
  Hits        69877                              69877              
+ Misses      18475                              18484       +9     
Files Changed Coverage
/runtime/common/src/weights/pallet_assets.rs 8.88% (-0.06%) 🔽
/runtime/common/src/weights/pallet_parachain_staking.rs 19.36% (-0.23%) 🔽
/runtime/common/src/weights/pallet_xcm.rs 5.23% (-0.03%) 🔽

Coverage generated Thu Oct 10 14:26:15 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants