use state_version 1 when running benchmarks #3006
Open
+0
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B7-runtimenoteworthy
RomarQ
requested review from
a team,
noandrea and
gonzamontiel
and removed request for
a team
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2228 KB (no changes) ✅ Moonriver runtime: 2232 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2228 KB (+232 KB compared to latest release) Moonriver runtime: 2232 KB (+240 KB compared to latest release) |
|
Will the migration be done by the next release? We want to make sure that the state trie migration is fully done before switching the benchmarks |
That is the intention, didn't you try it? |
Coverage Report@@ Coverage Diff @@
## master rq/use-state_version_1-in-benches +/- ##
====================================================================
Coverage 79.06% 79.06% 0.00%
Files 305 305
Lines 88382 88382
====================================================================
Hits 69878 69878
Misses 18504 18504
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
With RT 3300, the state trie will be migrated to version 1. This means that weights in RT 3400 should be generated for a runtime with
state_versionset to 1.