Fix Prometheus #63
Merged
Fix Prometheus #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The corresponding fix upstream in Substrate paritytech/substrate#7306 |
crystalin
approved these changes
Oct 12, 2020
|
I was waiting to merge this because they are having wasm build problems upstream. However the build completed fine for me locally, and our CI is green. |
|
Okay, I'm going to merge this, and we'll pick up whatever improvements they're working on in paritytech/substrate#7306 when we start building off of substrate master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
async-stdto1.6.5which fixes the problem with our prometheus endpoint hanging. Prometheus is now working.Here's more context about the async-std issue async-rs/async-std#888
To grab metrics from the standalone node or parachain just
curl localhost:9615/metrics. To grab metrics from the relay chain node that is embedded in the parachain node runcurl localhost:9616/metrics.