Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the collator reward wrong percentage #832

Merged
merged 3 commits into from
Sep 19, 2021

Conversation

crystalin
Copy link
Collaborator

What does it do?

Collators were given 20% of the minted token MINUS the 30% of parachain bond reserve.
This PR fixes it and issue 20% of the total minted token for that collator

@crystalin crystalin added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Sep 18, 2021
Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is correct, made #833 against this PR to update the unit/integration tests

@4meta5
Copy link
Contributor

4meta5 commented Sep 19, 2021

issue 20% of the total minted token for that collator

The collator commission is now 20% of the total minted token supply. Collators will get much more than 20% because their self bond essentially counts as a nomination and gets part of that 50%.

@crystalin
Copy link
Collaborator Author

Yes, this is how we explained it

@crystalin crystalin merged commit ef56a04 into master Sep 19, 2021
@crystalin crystalin deleted the crystalin-fix-reward-logic branch September 19, 2021 16:27
crystalin added a commit that referenced this pull request Sep 19, 2021
* Fixes the collator reward wrong percentage

* Small optimization

* update tests (#833)

Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
@crystalin crystalin mentioned this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants