Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdloan with change reward address origin #873

Merged
merged 5 commits into from
Oct 4, 2021

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Oct 1, 2021

What does it do?

Adapts change reward key association to a signature between "..." and configures the new associated type in crowdloan rewards

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@girazoki girazoki added the B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes label Oct 1, 2021
@girazoki girazoki marked this pull request as ready for review October 1, 2021 18:10
@girazoki girazoki added the A0-pleasereview Pull request needs code review. label Oct 4, 2021
@crystalin crystalin added A8-mergeoncegreen Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels Oct 4, 2021
@girazoki girazoki merged commit bddf8d9 into master Oct 4, 2021
@girazoki girazoki deleted the crowdloan_with_change_reward_address_origin branch October 4, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants