-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial review of Moonbeam (Phase 0) #924
Conversation
runtime/moonbeam/src/lib.rs
Outdated
pub const MOONRIVER_FACTOR: Balance = 100; // 100 more total supply | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Moonbeam is the flagship product, does it make more sense to have such a factor in the Moonriver runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, but this would imply division (or multiplying by a fraction) :)
I agree, though, it makes more sense to define this either (1) as a portion of total/genesis supply or (2) relative to GMLR
/// Default BlocksPerRound is every hour (300 * 12 second block times) | ||
pub const DefaultBlocksPerRound: u32 = 300; | ||
/// Collator candidate exits are delayed by 2 hours (2 * 300 * block_time) | ||
/// Default BlocksPerRound is every 4 hours (1200 * 12 second block times) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// Default BlocksPerRound is every 4 hours (1200 * 12 second block times) | |
/// Default BlocksPerRound is every 4 hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🌔
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
No description provided.