-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Girazoki allowance in assets precompile should work now #983
Merged
girazoki
merged 26 commits into
master
from
girazoki-allowance-precompile-should-work-now
Nov 12, 2021
Merged
Girazoki allowance in assets precompile should work now #983
girazoki
merged 26 commits into
master
from
girazoki-allowance-precompile-should-work-now
Nov 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6190814.
Co-authored-by: girazoki <gorka.irazoki@gmail.com>
girazoki
added
the
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
label
Nov 11, 2021
girazoki
changed the title
Girazoki allowance precompile should work now
Girazoki allowance in assets precompile should work now
Nov 11, 2021
…girazoki-allowance-precompile-should-work-now
JoshOrndorff
approved these changes
Nov 11, 2021
…e-precompile-should-work-now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It adds the allowance, name, symbol and decimals getters to the assets ERC20 contract, plus it also fixes the previous approval hack
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?