Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin nimbus branch to 94e54bd #986

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Nov 11, 2021

What does it do?

Updates Nimbus to a new commit which reverts the renaming of its runtime API, which avoids conflicts between client and runtime.

Without this, the client in this release would not be able to find the correct runtime API for NimbusApi and would throw this error:

Could not find `NimbusApi` version.

@notlesh notlesh added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Nov 11, 2021
@crystalin crystalin added A8-mergeoncegreen Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels Nov 12, 2021
@crystalin crystalin merged commit 6fdccb0 into master Nov 12, 2021
@crystalin crystalin deleted the notlesh-revert-nimbus-rename branch November 12, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants