Add delivery fees #479
Merged
Add delivery fees #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e672e9.
Coverage Report@@ Coverage Diff @@
## master girazoki-add-delivery-fees +/- ##
=============================================================
Coverage 64.81% 64.81% 0.00%
Files 66 66
Lines 9906 9906
=============================================================
Hits 6420 6420
Misses 3486 3486
|
Merged
girazoki
added
a0-pleasereview
Agusrodri
reviewed
Apr 2, 2024
Agusrodri
reviewed
Apr 4, 2024
| return filteredEvents[0]!.data[1][0].fun.asFungible.toBigInt(); | ||
| }; | ||
|
|
||
| export const getLastSentUmpMessageFee = async (context: DevModeContext, baseDelivery: bigint, txByteFee: bigint) => { |
There was a problem hiding this comment.
Really useful functions :)
Agusrodri
approved these changes
Apr 4, 2024
fgamundi
approved these changes
Apr 5, 2024
ParthDesai
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delivery fees for XCM routers in all runtimes (except Flashbox). We use
ExpontentialPricefrom polkadot-runtime-common and we charge in the native asset for each runtime.Added a couple function in TS so that we can check that indeed the messages are correctly charged. These take the latest fees from the sent messages available in storage