deprecate at least in container-chain nodes, native executor #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
B5-clientnoteworthy
Why? :D |
Just because we lose a bit of efficiency in our tests and those chains we have implementing the template untouched. But I guess it's more a bit of paranoia than anything else :) |
|
Okay :) |
ParthDesai
requested changes
May 2, 2024
ParthDesai
approved these changes
May 2, 2024
Coverage Report@@ Coverage Diff @@
## master girazoki-wasm-only-executor +/- ##
==============================================================
Coverage 65.25% 65.25% 0.00%
Files 68 68
Lines 10024 10024
==============================================================
Hits 6541 6541
Misses 3483 3483
|
girazoki
added a commit
that referenced
this pull request
May 2, 2024
* deprecate at least in container-chain nodes, native executor * make it compile * remove leftovers * leftovers agin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen a lot of people customizing the template runtime but not changing the spec name. This makes the full-nodes use the native compiled runtime and fail importing blocks.
I am not a big fan of doing it, but since it's the trend that comes from polkadot-sdk (see paritytech/polkadot-sdk#4329) I guess we should start using only the wasm-executor