Frontier Template: PoV Handling #716
Conversation
chexware
added
B7-runtimenoteworthy
Coverage Report@@ Coverage Diff @@
## master aleks-frontier-template-pov-handling +/- ##
========================================================================
+ Coverage 64.97% 65.27% +0.30%
Files 296 296
- Lines 51742 51502 -240
========================================================================
Hits 33615 33615
- Misses 18127 17887 -240
|
…pile-pallet-xcm to fix non-PoV test errors
…and manual_seal so blocks proofSize is displayed correctly
WASM runtime size check:Compared to target branchdancebox runtime: 1412 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 1816 KB (+1816 KB) container chain template simple runtime: 1096 KB (-4212 KB) ✅ container chain template frontier runtime: 1392 KB (-5132 KB) ✅ |
| @@ -50,8 +50,8 @@ describeSuite({ | |||
| const { result, block } = await context.createBlock(rawSigned); | |||
|
|
|||
| log(`block.proofSize: ${block.proofSize} (successful: ${result?.successful})`); | |||
| expect(block.proofSize).toBeGreaterThanOrEqual(15_000); | |||
| expect(block.proofSize).toBeLessThanOrEqual(25_000n + emptyBlockProofSize); | |||
| expect(block.proofSize).toBeGreaterThanOrEqual(30_000); | |||
There was a problem hiding this comment.
do these values make sense? why are they different to moonbeam ones?
There was a problem hiding this comment.
Our tests seems to fail with the original values. Reverted them in 58db5bd to new values and will be looking into resolving the issue now
| let contracts: HeavyContract[]; | ||
| let callData: `0x${string}`; | ||
| const MAX_CONTRACTS = 20; | ||
| const EXPECTED_POV_ROUGH = 38_000; // bytes |
There was a problem hiding this comment.
same thing with this, why is our expected pov different than moonbeam one?
There was a problem hiding this comment.
Our tests seems to fail with the original values. Reverted them in 58db5bd to new values and will be looking into resolving the issue now
This PR adds PoV configuration to the Frontier container chain template and relevant tests for it.
TO DO: