Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs related to Starlight > Ethereum sync using BEEFY #718

Open
wants to merge 2 commits into
base: girazoki-add-altair-diagram
Choose a base branch
from

Conversation

Agusrodri
Copy link
Collaborator

No description provided.

@Agusrodri Agusrodri changed the base branch from master to girazoki-add-altair-diagram October 9, 2024 20:57
@Agusrodri Agusrodri added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 1816 KB (+1816 KB) ⚠️

container chain template simple runtime: 1096 KB (-4212 KB) ✅

container chain template frontier runtime: 1396 KB (-5124 KB) ✅

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Coverage Report

(master)

@@                      Coverage Diff                      @@
##           master   agustin-add-beefy-diagram      +/-   ##
=============================================================
+ Coverage   64.97%                      65.29%   +0.32%     
  Files         296                         296              
- Lines       51742                       51468     -274     
=============================================================
- Hits        33615                       33605      -10     
- Misses      18127                       17863     -264     
Files Changed Coverage
/client/node-common/src/service.rs 48.31% (+0.23%)
/client/service-container-chain/src/service.rs 6.70% (-0.29%)
/client/service-container-chain/src/spawner.rs 44.66% (+0.22%)
/container-chains/nodes/frontier/src/cli.rs 73.33% (+6.66%)
/container-chains/nodes/frontier/src/command.rs 25.56% (+6.83%)
/container-chains/nodes/frontier/src/rpc/mod.rs 89.77% (+21.27%)
/container-chains/nodes/simple/src/command.rs 18.81% (+0.25%)
/node/src/service.rs 15.65% (+0.09%)

Coverage generated Wed Oct 9 21:42:48 UTC 2024

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me @Agusrodri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants