Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify to single CI platform #778

Merged
merged 16 commits into from
Dec 31, 2020
Merged

Unify to single CI platform #778

merged 16 commits into from
Dec 31, 2020

Conversation

atifaziz
Copy link
Member

This PR addresses #602 by unifying on AppVeyor as the single CI platform.

fsateler
fsateler reviewed Dec 30, 2020
View reviewed changes
Copy link
Member

@fsateler fsateler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

This looks interesting. Did you unify on appveyor only because it was easier? Or for another reason?

I ask, because Github Actions seems to be the new kid on the block everyone is talking about 😉

appveyor.yml Show resolved Hide resolved
@atifaziz
Copy link
Member Author

Did you unify on appveyor only because it was easier?

Yes, as I have already some experience with it.

Or for another reason?

Time. 😄

I ask, because Github Actions seems to be the new kid on the block everyone is talking about 😉

I know and I have tried it with just one project so I am barely proficient in it. Everything system needs time getting used to with some trial and error. I have been using AppVeyor for ages and it has served me well. It now supports Linux and macOS images so it was the path of least friction. I am happy to move to GitHub Actions if someone well-versed in it can help with the setup and maintenance. However, given that issue #602 has been open since over a year and no one really picked it up, I just wanted to get this sorted out for now so we can move to more interesting (less infrastructural) work.

fsateler
fsateler approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@fsateler fsateler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atifaziz atifaziz merged commit 55744f2 into morelinq:master Dec 31, 2020
@atifaziz atifaziz deleted the one-ci branch December 31, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsateler fsateler fsateler approved these changes

Assignees
No one assigned
Labels
Component-Scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atifaziz @fsateler